fix(utils): map common Linux filesystem magic values#3023
Merged
Conversation
Contributor
|
CLA requirements are satisfied for this pull request. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves Linux filesystem type detection in rustfs-utils by adding verified magic-number mappings for XFS and BTRFS, and refactoring the mapping into a shared module so it can be unit-tested even on non-Linux hosts.
Changes:
- Added XFS (
0x58465342) and BTRFS (0x9123683E) filesystem magic mappings. - Moved the filesystem magic mapping helper out of
os/linux.rsinto a newos/fs_type.rsmodule. - Added unit tests covering the new magic-number mappings and preserved unverified mappings as TODOs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/utils/src/os/mod.rs | Adds the new fs_type module to the OS utilities module tree. |
| crates/utils/src/os/linux.rs | Switches Linux disk info code to use the shared get_fs_type helper. |
| crates/utils/src/os/fs_type.rs | Introduces a shared filesystem-magic mapping helper and unit tests for XFS/BTRFS. |
houseme
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backlog: rustfs/backlog#646
Validation
PATH="$HOME/.cargo/bin:$PATH" cargo test -p rustfs-utils --features os map_common_linux_filesystem_magic_numbers -- --nocapturefailed withUNKNOWNfor XFS before adding the mappings.PATH="$HOME/.cargo/bin:$PATH" cargo test -p rustfs-utils --features os map_common_linux_filesystem_magic_numbers -- --nocapturePATH="$HOME/.cargo/bin:$PATH" cargo test -p rustfs-utils --features os os:: -- --nocapturePATH="$HOME/.cargo/bin:$PATH" cargo fmt --all --checkPATH="$HOME/.cargo/bin:$PATH" cargo clippy -p rustfs-utils --features os --tests -- -D warningsPerformance