fix(obs): remove stale replication metric TODOs#3024
Merged
Conversation
Contributor
|
CLA requirements are satisfied for this pull request. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up bucket replication proxy metric schema documentation by removing stale TODO comments and strengthens regression coverage by asserting that DELETE tagging proxied total and failure metrics are emitted by the bucket replication metrics collector.
Changes:
- Removed outdated TODO comments in the bucket replication metric schema where the referenced metrics already exist.
- Updated the bucket replication collector unit test to assert emission (name/labels/value) of DELETE tagging proxied total and failures metrics.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/obs/src/metrics/schema/bucket_replication.rs | Removes stale TODO comments now that the relevant proxied tagging metrics are already defined. |
| crates/obs/src/metrics/collectors/bucket_replication.rs | Adds/adjusts unit test assertions to validate DELETE tagging proxied total/failure metrics are emitted. |
houseme
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backlog: rustfs/backlog#646
Validation
PATH="$HOME/.cargo/bin:$PATH" cargo test -p rustfs-obs test_collect_bucket_replication_metrics -- --nocapturePATH="$HOME/.cargo/bin:$PATH" cargo fmt --all --checkPATH="$HOME/.cargo/bin:$PATH" cargo clippy -p rustfs-obs --tests -- -D warningsPerformance