Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues with the scandir object implementation, primarily addressing bug #635. The changes refactor the merge entry channels logic and improve the scan_dir function's parameter handling.
Key changes:
- Refactored
merge_entry_channelsto eliminate redundant cloning and simplify the entry comparison logic - Modified
scan_dirto accept owned parameters instead of mutable references, reducing complexity and improving performance - Cleaned up commented-out code and improved error logging
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| crates/ecstore/src/store_list_objects.rs | Simplified merge_entry_channels by removing unnecessary Option wrapping and cloning, changed loop iteration pattern |
| crates/ecstore/src/disk/local.rs | Changed scan_dir signature from mutable references to owned parameters, removed filter_prefix handling from recursive calls, improved prefix checking logic |
| crates/ecstore/src/cache_value/metacache_set.rs | Fixed comment text for clarity |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: scandir object
Type of Change
Related Issues
#635
Summary of Changes
Checklist
make pre-commitImpact
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.