fix(component): unwrap posting-level meta-values (symmetric)#180
Merged
Conversation
Posting metadata (`list<meta-entry>`) marshalled its meta-values tagged
(`{"type":"text","value":...}`), where directive `meta.user` is unwrapped —
so e.g. an `overage: "12.34 GB"` posting-meta filter saw a dict, not the
string.
Unwrap meta-values in any `list<meta-entry>` pair-list in `_marshal`, and —
crucially — re-tag them in `_unmarshal` (via `_meta_value_json`), mirroring the
`meta.user` path. A `_marshal`-only unwrap broke the clamp round-trip (the
earlier naive attempt regressed the suite); doing both directions keeps it
intact. Full suite via component: 5 -> 4 failures, no regressions.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #173 (1 of the remaining 5). Posting metadata (
list<meta-entry>) marshalled its meta-values tagged ({"type":"text","value":...}), whereas directivemeta.useris unwrapped — so e.g.any(overage:"GB$")saw a dict instead of the string"12.34 GB"and matched nothing.Fix (symmetric — the key detail)
_marshal: unwrap meta-values in anylist<meta-entry>pair-list._unmarshal: re-tag them via_meta_value_json, mirroring themeta.userpath.A
_marshal-only unwrap regressed the suite 5→17 (the tagged shape is coupled to the clamp/_unmarshalround-trip). Doing both directions keeps the round-trip intact.Impact
Full suite via the component: 5 → 4 failures, no regressions (
test_advanced_filter[overage]passes; component round-trip unit tests green). ruff + mypy clean. Default JSON-RPC path unaffected.Remaining 4 are rustledger-side (clamp provenance +
loadfilename arg), tracked in #173.