Update to serde 1.0 with tests still passing#29
Merged
s-panferov merged 1 commit intos-panferov:masterfrom Mar 7, 2018
ErichDonGubler:serde-1.0
Merged
Update to serde 1.0 with tests still passing#29s-panferov merged 1 commit intos-panferov:masterfrom ErichDonGubler:serde-1.0
serde 1.0 with tests still passing#29s-panferov merged 1 commit intos-panferov:masterfrom
ErichDonGubler:serde-1.0
Conversation
BREAKING CHANGE: Force the current doc examples to `unwrap` their code, since now
`serde_json::to_value` returns a `Result`.
BREAKING CHANGE: Make downstream update any custom serializers they may have used to conform to the
new `serde` API. This is expected, and not too big of a deal for people who want to upgrade to
the new versions of `serde`. Basically, one only needs to change the `&mut S` argument to `S`,
and use `S::Ok` instead of `()` for the `Result`.
BREAKING CHANGE: Rename `find` usages in the docs to its isomorphic successor API `get`.
BREAKING CHANGE: Replace `find_path` usages in the docs with usages of the new `pointer` API.
Closes issue #26.
ErichDonGubler
changed the title
serde 1.0serde 1.0 with test still passing
ErichDonGubler
changed the title
serde 1.0 with test still passingserde 1.0 with tests still passing
|
This is awesome, really interested on this. @s-panferov Any chances of reviewing this? |
|
👍 I hope this PR can revive this project |
Owner
|
I'll try to merge this at weekend |
Contributor
Author
|
@s-panferov: Any update on when this can be given some attention? :) I'm available for any questions you may have about these changes, in case the PR doesn't attend to some concern you may have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unwraptheir code, since nowserde_json::to_valuereturns aResult.serdeAPI. This is expected, and not too big of a deal for people who want to upgrade to the new versions ofserde. Basically, one only needs to change the&mut Sargument toS, and useS::Okinstead of()for theResult.findusages in the docs to its isomorphic successor APIget.find_pathusages in the docs with usages of the newpointerAPI.Closes issue #26.
NOTE that this PR is distinct from #27, which has a few broken tests. This PR has ALL tests passing with minimum modifications necessary in order to make tests build again.
This PR depends on the
serde1.0 bump that I've also submitted againstjsonway. This PR will break in CI until that PR is merged and a new version ofjsonwayis accessible viacrates.io. It may be interesting to discuss the following for this PR:jsonwayfor this library now that there is ajson!macro inserde_jsonthat seems to approach the same problem domain as that library. I probably don't know enough about it, though -- I'm not sure what the breadth of use cases are thatjsonwayintends to handle.