Skip to content

Conversation

@lucab
Copy link
Contributor

@lucab lucab commented Sep 16, 2025

This adds two methods to the existing StartHandshake in order to allow splitting and reconstructing the underlying components.

For context and usecase, see #125.

This adds two methods to the existing `StartHandshake` in order to
allow splitting and reconstructing the underlying components.
Copy link
Member

@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the other option would be to make these fields public -- this API also commits us to never adding new fields that need non-trivial values (and I think this is OK for this struct).

@djc djc merged commit a58a6e9 into rustls:main Sep 17, 2025
6 checks passed
@djc
Copy link
Member

djc commented Sep 17, 2025

I guess the other option would be to make these fields public -- this API also commits us to never adding new fields that need non-trivial values (and I think this is OK for this struct).

I'll follow up on that.

@lucab
Copy link
Contributor Author

lucab commented Sep 17, 2025

I guess the other option would be to make these fields public

Indeed. Two options I considered (and discarded) before opening this PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants