Skip to content

Make StartHandshake fields public #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 17, 2025
Merged

Make StartHandshake fields public #128

merged 4 commits into from
Sep 17, 2025

Conversation

@djc
Copy link
Member

@djc djc commented Sep 17, 2025

@djc djc requested review from cpu, ctz and quininer September 17, 2025 07:35
@djc djc force-pushed the start-public-fields branch from 6a3011a to 2102fbb Compare September 17, 2025 07:38
@lucab
Copy link
Contributor

lucab commented Sep 17, 2025

Thanks for the followup! This arrangement too works for me.
I think this also makes #126 redundant.

The only comment I have is that this version now also allows access patterns like &mut start_handshake.io and &mut start_handshake.accepted. Not sure if that's on purpose, but I guess it is nice to have.

@djc djc merged commit e0ddd89 into main Sep 17, 2025
6 checks passed
@djc djc deleted the start-public-fields branch September 17, 2025 08:22
@djc djc mentioned this pull request Sep 17, 2025
Merged
@lucab lucab mentioned this pull request Sep 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctz ctz ctz approved these changes

@cpu cpu Awaiting requested review from cpu

@quininer quininer Awaiting requested review from quininer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@djc @lucab @ctz