Skip to content

Prepare 0.104.0-alpha.5#457

Merged
ctz merged 1 commit intomainfrom
jbp-bumpo
Mar 20, 2026
Merged

Prepare 0.104.0-alpha.5#457
ctz merged 1 commit intomainfrom
jbp-bumpo

Conversation

@ctz
Copy link
Member

@ctz ctz commented Mar 20, 2026

Release notes:

Correct selection of candidate CRLs by Distribution Point and Issuing Distribution Point. If a certificate had more than one distributionPoint, then only the first distributionPoint would be considered against each CRL's IssuingDistributionPoint distributionPoint, and then the certificate's subsequent distributionPoints would be ignored.

The impact was that correct provided CRLs would not be consulted to check revocation. With UnknownStatusPolicy::Deny (the default) this would lead to incorrect but safe Error::UnknownRevocationStatus. With UnknownStatusPolicy::Allow this would lead to inappropriate acceptance of revoked certificates.

This vulnerability is thought to be of limited impact. This is because both the certificate and CRL are signed -- an attacker would need to compromise a trusted issuing authority to trigger this bug. An attacker with such capabilities could likely bypass revocation checking through other more impactful means (such as publishing a valid, empty CRL.)

More likely, this bug would be latent in normal use, and an attacker could leverage faulty revocation checking to continue using a revoked credential.

This vulnerability is identified by GHSA-pwjx-qhcg-rvj4. Thank you to @1seal for the report.

@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.68%. Comparing base (447347c) to head (6ddada3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #457   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files          20       20           
  Lines        3896     3896           
=======================================
  Hits         3767     3767           
  Misses        129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctz ctz mentioned this pull request Mar 20, 2026
@ctz
Copy link
Member Author

ctz commented Mar 20, 2026

updated discussion of severity/impact to remove cvss

@ctz ctz added this pull request to the merge queue Mar 20, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 20, 2026
@ctz ctz added this pull request to the merge queue Mar 20, 2026
Merged via the queue into main with commit a531696 Mar 20, 2026
26 checks passed
@ctz ctz deleted the jbp-bumpo branch March 20, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants