Skip to content

trtexec-rs#49

Merged
theHamsta merged 19 commits intorustnn:mainfrom
theHamsta:trtexec-rs
Apr 21, 2026
Merged

trtexec-rs#49
theHamsta merged 19 commits intorustnn:mainfrom
theHamsta:trtexec-rs

Conversation

@theHamsta
Copy link
Copy Markdown
Contributor

I thought it would be nice to have small CLI utility to dogfood features of this crate and profile trtx, test engine caching hashes and maybe also add RustNN input files.

@theHamsta theHamsta force-pushed the trtexec-rs branch 5 times, most recently from b01741c to d58a5c7 Compare April 10, 2026 10:11
@theHamsta
Copy link
Copy Markdown
Contributor Author

Made a few tweaks to the API as I discovered problems. Split up into two different PRs?

I also added support for .webnn/webnn.json files, this has the nice side effect that we can detect when we break RustNN

@theHamsta theHamsta force-pushed the trtexec-rs branch 4 times, most recently from 3b7dfb3 to eed722d Compare April 10, 2026 11:28
@theHamsta
Copy link
Copy Markdown
Contributor Author

protoc installation still failing on windows. this is how prost itself installs it https://github.com/tokio-rs/prost/blob/master/.github/workflows/ci.yml#L63C1-L66C49 (indirectly from the github releases of protobuf)

@theHamsta theHamsta force-pushed the trtexec-rs branch 3 times, most recently from 549d0b7 to 069f6f5 Compare April 10, 2026 12:24
@theHamsta theHamsta marked this pull request as ready for review April 10, 2026 12:50
@theHamsta theHamsta force-pushed the trtexec-rs branch 4 times, most recently from e4f8316 to c99f2aa Compare April 10, 2026 13:52
Comment thread .github/workflows/ci.yml Outdated
@mtavenrath
Copy link
Copy Markdown
Contributor

I also added support for .webnn/webnn.json files, this has the nice side effect that we can detect when we break RustNN

doesn't this add some kind of circular reference between trtx-rs and rustnn? I'd prefer to support those formats only in rustnn and/or webnn-graph applications.

@mtavenrath
Copy link
Copy Markdown
Contributor

Made a few tweaks to the API as I discovered problems. Split up into two different PRs?
Probably that's preferable in case someone does git archeology.

Copy link
Copy Markdown
Contributor

@mtavenrath mtavenrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread .github/workflows/ci.yml Outdated
Comment thread trtexec-rs/src/main.rs Outdated
Comment thread trtexec-rs/src/main.rs
@theHamsta
Copy link
Copy Markdown
Contributor Author

I also added support for .webnn/webnn.json files, this has the nice side effect that we can detect when we break RustNN

doesn't this add some kind of circular reference between trtx-rs and rustnn? I'd prefer to support those formats only in rustnn and/or webnn-graph applications.

Not really as the dependency is

trtx-sys -> trtx -> trtexec-rs
trtx-sys -> trtx -> rustnn (with patched deps) -> trtexec-rs

It is true, that pushing to crates.io would require trtexec-rs to depend on non-git dependencies

@theHamsta theHamsta force-pushed the trtexec-rs branch 2 times, most recently from 22b3c3f to 8b4aef3 Compare April 18, 2026 19:46
@theHamsta theHamsta force-pushed the trtexec-rs branch 6 times, most recently from 275223f to 8bdc4a1 Compare April 20, 2026 10:04
@theHamsta theHamsta requested a review from mtavenrath April 20, 2026 10:41
@theHamsta theHamsta merged commit 322eba3 into rustnn:main Apr 21, 2026
5 checks passed
@theHamsta theHamsta deleted the trtexec-rs branch April 21, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants