Skip to content

Conversation

@rustprooflabs
Copy link
Owner

Closes #265, in response to #264.

I verified this additional test run catches the issue if I revert the change in #264.

<truncated output>
Post-processing road_major

2022-11-25 08:11:35,839:INFO:pgosm-flex:pgosm_flex:Skipping calculating nested polygons
Traceback (most recent call last):
  File "/app/docker/pgosm_flex.py", line 538, in <module>
    run_pgosm_flex()
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/app/docker/pgosm_flex.py", line 111, in run_pgosm_flex
    success = run_osm2pgsql_standard(input_file=input_file,
  File "/app/docker/pgosm_flex.py", line 178, in run_osm2pgsql_standard
    pbf_filename=pbf_filename)
UnboundLocalError: local variable 'pbf_filename' referenced before assignment
make: *** [Makefile:113: docker-exec-append-w-input-file] Error 1

@rustprooflabs rustprooflabs added the enhancement New feature or request label Nov 25, 2022
@rustprooflabs rustprooflabs added this to the 0.6.2 milestone Nov 25, 2022
@rustprooflabs
Copy link
Owner Author

Bonus: Switched layerset to minimal (from default) on steps that are only testing functional abilities of the in-Docker processing, and not the data itself. This change makes the full make process to run 38% faster (knocked off 57 seconds).

Before this change:

real	2m27.436s

After

real	1m30.863s

@rustprooflabs rustprooflabs changed the title Add execution step to test initial --append call with --input-file Add Make step to test initial --append call with --input-file Nov 25, 2022
@rustprooflabs rustprooflabs merged commit 7a12896 into main Nov 25, 2022
@rustprooflabs rustprooflabs deleted the makefile-test-append branch November 25, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests to Makefile covering --append

2 participants