fix: use std::vector for dynamically sized array in gather.cpp and segment.cpp #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 15 15
Lines 143 143
=====================================
Hits 143 143Continue to review full report at Codecov.
|
Novare
changed the title
Author
|
I also fixed this in segment.cpp as the error was identical there. |
Owner
|
Great. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes "error C2131: expression did not evaluate to a constant" during compilation.
This error is caused by the lambda function in gather.cpp both in lines 44 to 66 and 105 to 137 using a variable length array "vals[K]". Regular C-Style Arrays need to be initialized with a constant expression that can be evaluated during compilation. Replacing this with a std::vector<scalar_t> initialized with K zeros solves the problem.