Add comprehensive test coverage for GTU7 GPS sensor#17
Merged
Conversation
Co-authored-by: rustyeddy <2903425+rustyeddy@users.noreply.github.com>
Co-authored-by: rustyeddy <2903425+rustyeddy@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Update PR to address feedback on Gtu7 sensor and drivers
Add comprehensive test coverage for GTU7 GPS sensor
Jan 16, 2026
rustyeddy
approved these changes
Jan 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage for the GTU7 GPS sensor driver to address review feedback. The tests verify the driver's robustness in handling malformed NMEA sentences, operating with limited sentence types, responding to context cancellation, and supporting multi-constellation GNSS formats (GPS+GLONASS/Galileo).
Changes:
- Added tests for malformed/invalid NMEA sentence handling (empty lines, truncated data, unknown types, missing fields)
- Added test for GGA-only operation without RMC/VTG speed data
- Added test for context cancellation behavior
- Added tests for multi-constellation GNSS sentence variants (GNGGA/GNRMC/GNVTG)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback requesting additional test scenarios beyond the existing RMC precedence test.
Tests Added
Example test structure:
All tests use string readers (hermetic, deterministic) and follow existing timeout patterns.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.