Skip to content

[WIP] Update Gtu7 sensor and serial drivers implementation#22

Merged
rustyeddy merged 3 commits intogtu7from
copilot/sub-pr-16-please-work
Jan 17, 2026
Merged

[WIP] Update Gtu7 sensor and serial drivers implementation#22
rustyeddy merged 3 commits intogtu7from
copilot/sub-pr-16-please-work

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 16, 2026

Thanks for the feedback on #16. I've created this new PR, which merges into #16, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.

Original PR: #16
Triggering review: #16 (comment)

@copilot open a new pull request to apply changes based on this feedback


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: rustyeddy <2903425+rustyeddy@users.noreply.github.com>
@rustyeddy rustyeddy marked this pull request as ready for review January 16, 2026 17:58
Copilot AI review requested due to automatic review settings January 16, 2026 17:58
Co-authored-by: rustyeddy <2903425+rustyeddy@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the missing Access field to the GTU7 GPS sensor's descriptor, setting it to ReadOnly to match the access pattern of other read-only sensors in the codebase.

Changes:

  • Added Access: devices.ReadOnly field to the GTU7 sensor's Descriptor() method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sensors/gtu7.go
@rustyeddy rustyeddy merged commit 80a0f22 into gtu7 Jan 17, 2026
1 check failed
@rustyeddy rustyeddy deleted the copilot/sub-pr-16-please-work branch January 17, 2026 16:08
Copilot stopped work on behalf of rustyeddy due to an error January 17, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants