Conversation
Co-authored-by: rustyeddy <2903425+rustyeddy@users.noreply.github.com>
Co-authored-by: rustyeddy <2903425+rustyeddy@users.noreply.github.com>
Co-authored-by: rustyeddy <2903425+rustyeddy@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] WIP Address feedback on Gtu7 sensor and serial drivers implementation
Fix parseLatLon to detect and return strconv.ParseFloat errors
Jan 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the parseLatLon function where strconv.ParseFloat errors were silently ignored, causing invalid coordinate strings to return (0, 0) instead of propagating the error. This masked parse failures since (0, 0) represents valid coordinates in the Gulf of Guinea.
Changes:
- Added proper error handling for latitude and longitude parsing with descriptive wrapped error messages
- Improved the empty string error message for clarity
- Added the
fmtimport for error formatting - Added a new
TestParseLatLontest function with 7 test cases
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sensors/gtu7.go | Fixed error handling in parseLatLon to check and return strconv.ParseFloat errors with wrapped messages; improved empty string error message |
| sensors/gtu7_test.go | Added TestParseLatLon test function with test cases for valid coordinates, empty strings, and invalid inputs (incomplete implementation) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
parseLatLonfunction silently ignoredstrconv.ParseFloaterrors, causing invalid coordinate strings to return(0, 0)— valid coordinates in the Gulf of Guinea — masking parse failures.Changes:
fmtimport for error formattingBefore:
After:
Callers in
parseGPGGAandparseGPRMCalready handle the error return appropriately.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.