Embed devices.Base in GTU7 to implement complete Device interface#27
Closed
Embed devices.Base in GTU7 to implement complete Device interface#27
Conversation
Co-authored-by: rustyeddy <2903425+rustyeddy@users.noreply.github.com>
Co-authored-by: rustyeddy <2903425+rustyeddy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback from PR #16 on Gtu7 sensor
Embed devices.Base in GTU7 to implement complete Device interface
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GTU7 struct was missing the
Events()method required by the Device interface. VH400 and other sensors implement this by embeddingdevices.Base.Changes
devices.Basein GTU7 struct to provideName()andEvents()methodsNewGTU7with event buffer size of 16Run(): EventOpen at start, EventClose/EventError on exit, and close events channelExample
Pattern now matches VH400 and polling-based sensors.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.