Add test coverage for serial driver implementation#32
Closed
Conversation
Added test coverage for serial driver implementation including: - Configuration validation tests (empty port, zero/negative baud) - Baud rate conversion tests (all supported rates + error cases) - Error handling for invalid configs and unsupported baud rates - Interface compliance tests - String formatting tests All tests are hermetic and follow testify patterns per AGENTS.md Co-authored-by: rustyeddy <2903425+rustyeddy@users.noreply.github.com>
Fixed test name generation in TestBaudToUnixAllSupportedRates to use fmt.Sprintf instead of string(rune(baud)), which was producing non-printable characters. Test names now correctly display as "4800", "9600", etc. Co-authored-by: rustyeddy <2903425+rustyeddy@users.noreply.github.com>
Co-authored-by: rustyeddy <2903425+rustyeddy@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Address feedback on Gtu7 sensor and serial drivers integration
Add test coverage for serial driver implementation
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The serial driver implementation (
drivers/serial_linux.go) lacked test coverage for critical low-level logic including termios configuration, baud rate mapping, and file descriptor management.Changes
drivers/serial_test.go- Platform-agnostic validation tests:drivers/serial_linux_test.go- Linux-specific driver tests:All tests are hermetic (no hardware interaction) and follow repository patterns (testify assertions, parallel execution, table-driven where applicable).
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.