Add Tags and Attributes to GTU7 Descriptor#33
Merged
Conversation
- Added Tags: "gps", "navigation", "location" - Added Attributes: serial port and baud rate information - Added Access: ReadOnly to match other sensor patterns - Store GTU7Config in struct to access serial info in Descriptor - Added comprehensive tests for Descriptor functionality Co-authored-by: rustyeddy <2903425+rustyeddy@users.noreply.github.com>
Co-authored-by: rustyeddy <2903425+rustyeddy@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Update Gtu7 sensor and serial drivers implementation based on feedback
Add Tags and Attributes to GTU7 Descriptor
Jan 16, 2026
rustyeddy
deleted the
copilot/sub-pr-16-558c2f3f-b2e0-4977-90f7-09652a474f2b
branch
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the GTU7 GPS sensor's Descriptor method to include metadata fields (tags and attributes) similar to other sensors like VH400, improving discoverability and documentation.
Changes:
- Added
cfgfield to GTU7 struct to store configuration - Enhanced Descriptor() method to include tags ("gps", "navigation", "location") and attributes (serial port and baud rate when configured)
- Added comprehensive test coverage for both serial config and no-config scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sensors/gtu7.go | Added cfg field to struct and enhanced Descriptor() to populate tags and attributes from serial configuration |
| sensors/gtu7_test.go | Added TestGTU7_Descriptor with test cases for both with and without serial configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+107
to
+113
| attrs := make(map[string]string) | ||
| if g.cfg.Serial.Port != "" { | ||
| attrs["port"] = g.cfg.Serial.Port | ||
| } | ||
| if g.cfg.Serial.Baud > 0 { | ||
| attrs["baud"] = strconv.Itoa(g.cfg.Serial.Baud) | ||
| } |
There was a problem hiding this comment.
The g.cfg field will always be zero-valued because it's not initialized in NewGTU7 (line 97-101). This means attrs["port"] and attrs["baud"] will never be populated since g.cfg.Serial.Port will be empty and g.cfg.Serial.Baud will be 0. The NewGTU7 function needs to be updated to include cfg: cfg in the return statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GTU7 sensor's Descriptor was missing metadata fields present in other sensors like VH400, reducing discoverability and documentation quality.
Changes:
"gps","navigation","location"portandbaudrate when configuredReadOnlyGTU7Configin struct to populate Attributes from serial configurationExample:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.