Fix crashes, silent bugs, and design issues from code review#1
Merged
Conversation
Owner
rustyeddy
commented
Jun 1, 2026
rustyeddy
commented
- Fix recursive Cam.Close() and MJPEG.Close() (infinite loop/stack overflow)
- Add missing Window.Close() to satisfy ImOut interface
- Fix Img.Play() staying running after single frame (main loop hang)
- Fix VideoFile.Close() not stopping reader goroutine (panic on closed channel)
- Fix malformed JSON struct tags in config.go (fields not marshaling)
- Remove debug fmt.Println from main.go
- Replace deprecated ioutil.WriteFile with os.WriteFile
- Remove dead code: Pipeline.Close() no-op loop and unused Pipe struct
- Mark ColorDetector.Filter() as a stub
- Add graceful shutdown via OS signal handling (SIGINT/SIGTERM)
- Fan-out frame dispatch to outputs concurrently with sync.WaitGroup
- Fix recursive Cam.Close() and MJPEG.Close() (infinite loop/stack overflow) - Add missing Window.Close() to satisfy ImOut interface - Fix Img.Play() staying running after single frame (main loop hang) - Fix VideoFile.Close() not stopping reader goroutine (panic on closed channel) - Fix malformed JSON struct tags in config.go (fields not marshaling) - Remove debug fmt.Println from main.go - Replace deprecated ioutil.WriteFile with os.WriteFile - Remove dead code: Pipeline.Close() no-op loop and unused Pipe struct - Mark ColorDetector.Filter() as a stub - Add graceful shutdown via OS signal handling (SIGINT/SIGTERM) - Fan-out frame dispatch to outputs concurrently with sync.WaitGroup Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.