Conversation
When a class is imported with the same namespace as the current file, its short name is now recorded as a reserved alias rather than silently returned. Without the reservation, a later import from a different namespace with the same short name was also returned unaliased, so the generated file ended up with `use X\Y\Foo;` alongside a `class Foo` declaration — which PHP rejects as a redeclaration. `findAvailableAlias` already bumps colliding entries to `Foo2`, so recording the reservation is enough to make conflicting external imports flow through that path automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a class is imported with the same namespace as the current file, its short name is now recorded as a reserved alias rather than silently returned. Without the reservation, a later import from a different namespace with the same short name was also returned unaliased, so the generated file ended up with
use X\Y\Foo;alongside aclass Foodeclaration — which PHP rejects as a redeclaration.findAvailableAliasalready bumps colliding entries toFoo2, so recording the reservation is enough to make conflicting external imports flow through that path automatically.