fix(rvlite): macOS linking bug — platform-specific errno#188
Merged
Conversation
rvlite's writer_lease.rs used __errno_location (Linux libc) under a generic #[cfg(unix)] guard, causing link failures on macOS where the equivalent is __error. Split the extern and wrapper into separate #[cfg(target_os)] blocks matching the pattern already used in rvf-runtime/src/locking.rs. Closes #174 Co-Authored-By: claude-flow <ruv@ruv.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rvlitewhere__errno_location(Linux libc) was used under a generic#[cfg(unix)]guard instead of the macOS equivalent__errorChanges
extern "C"declarations anderrno_location()wrapper incrates/rvlite/src/storage/writer_lease.rsinto platform-specific#[cfg(target_os)]blocks__errno_location()__error()crates/rvf/rvf-runtime/src/locking.rsCloses #174
Test plan
cargo check -p rvlitepasses on LinuxGenerated with claude-flow