Skip to content

fix(diskann): seed test RNGs to fix flaky test_diskann_basic #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruvnet merged 1 commit into from
Apr 27, 2026
Merged

fix(diskann): seed test RNGs to fix flaky test_diskann_basic #397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions crates/ruvector-diskann/src/index.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,10 @@ mod tests {

fn random_vectors(n: usize, dim: usize) -> Vec<(String, Vec<f32>)> {
use rand::prelude::*;
let mut rng = rand::thread_rng();
// Seeded so tests are deterministic across CI runs — random data made
// basic-search assertions (nearest of vec-X is vec-X) flake when the
// ANN graph traversal happened to land on an unrelated near-duplicate.
let mut rng = rand::rngs::StdRng::seed_from_u64(0xD15CA77);
(0..n)
.map(|i| {
let v: Vec<f32> = (0..dim).map(|_| rng.gen()).collect();
Expand Down Expand Up @@ -512,7 +515,7 @@ mod tests {
fn test_recall_at_10() {
// Measure recall@10: what fraction of true top-10 neighbors does DiskANN find?
use rand::prelude::*;
let mut rng = rand::thread_rng();
let mut rng = rand::rngs::StdRng::seed_from_u64(0xD15CA77);
let n = 2000;
let dim = 64;
let k = 10;
Expand Down Expand Up @@ -615,7 +618,7 @@ mod tests {
// 5000 vectors, 128-dim — should build in under 5 seconds
use rand::prelude::*;
use std::time::Instant;
let mut rng = rand::thread_rng();
let mut rng = rand::rngs::StdRng::seed_from_u64(0xD15CA77);

let n = 5000;
let dim = 128;
Expand Down
Loading