fix(mobile): clean up sockets when simulation starts#240
Closed
Gujiassh wants to merge 1 commit intoruvnet:mainfrom
Closed
fix(mobile): clean up sockets when simulation starts#240Gujiassh wants to merge 1 commit intoruvnet:mainfrom
Gujiassh wants to merge 1 commit intoruvnet:mainfrom
Conversation
When the server URL is cleared, close the active WebSocket and cancel pending reconnects so simulation mode does not race with stale network state. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Author
|
Quick validation from my side on the current branch tip:
So the websocket cleanup behavior covered by this PR is locally green on the current head. |
Author
|
Closing this stale radar PR to keep the queue clean: it has been open for weeks without maintainer response, and I am not going to keep it in the active follow-up set without renewed upstream interest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ws.service.ts, separate from open RuView PR scopes#151and#236Validation
cd ui/mobile && npm test -- --runInBand src/__tests__/services/ws.service.test.tsESLINT_USE_FLAT_CONFIG=false npx -y eslint@8 -c .eslintrc.js src/services/ws.service.ts src/__tests__/services/ws.service.test.ts(still fails because of a pre-existing repo ESLint/@typescript-eslint rule wiring mismatch, not because of this patch)Notes