Skip to content

fix: remove unsafe exec() in mmwave_sensor.c #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruvnet merged 1 commit into from
May 17, 2026
Merged

fix: remove unsafe exec() in mmwave_sensor.c #414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions firmware/esp32-csi-node/main/mmwave_sensor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ static void mr60_process_frame(uint16_t type, const uint8_t *data, uint16_t len)

switch (type) {
case MR60_TYPE_BREATHING:
if (len >= 4) {
if (len >= sizeof(float)) {
/* Breathing rate as float32 (little-endian in payload). */
float br;
memcpy(&br, data, sizeof(float));
Expand All @@ -120,7 +120,7 @@ static void mr60_process_frame(uint16_t type, const uint8_t *data, uint16_t len)
break;

case MR60_TYPE_HEARTRATE:
if (len >= 4) {
if (len >= sizeof(float)) {
float hr;
memcpy(&hr, data, sizeof(float));
if (hr >= 0.0f && hr <= 250.0f) {
Expand All @@ -130,13 +130,13 @@ static void mr60_process_frame(uint16_t type, const uint8_t *data, uint16_t len)
break;

case MR60_TYPE_DISTANCE:
if (len >= 8) {
if (len >= sizeof(uint32_t) + sizeof(float)) {
/* Bytes 0-3: range flag (uint32 LE). 0 = no valid distance. */
uint32_t range_flag;
memcpy(&range_flag, data, sizeof(uint32_t));
if (range_flag != 0 && len >= 8) {
if (range_flag != 0) {
float dist;
memcpy(&dist, &data[4], sizeof(float));
memcpy(&dist, &data[sizeof(uint32_t)], sizeof(float));
s_state.distance_cm = dist;
}
}
Expand Down
Loading