fix(ui): map sensing websocket port for docker#572
Merged
Conversation
ruvnet
approved these changes
May 17, 2026
Owner
ruvnet
left a comment
There was a problem hiding this comment.
Reviewed the diff:
buildSensingWsUrl()correctly handles the two documented deployment shapes (Docker 3000→3001, Python 8080→8765). For unrecognized HTTP ports the function falls back towindow.location.host, preserving same-port behaviour for any custom setup.getConnection(eventName)guard inwebsocket.service.jsis the right fix for the race where a callback fires after the connection map entry has been cleaned up. Logging the warning withurl + readyStatemakes the symptom observable.- New tests in
test-runner.jsexercise both the port-mapping logic and the cleanup race. - Default fallback host changed from
localhost:3000tolocalhost:3001— that matches the sensing-server's WS port in the Docker image, which is the right default for the demo path. Anyone running a custom HTTP+WS-on-same-port stack still works via the location fallback.
Approving + merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lastActivity.Validation
git diff --checknode --check ui/services/sensing.service.jsnode --check ui/services/websocket.service.jsnode --check ui/tests/test-runner.jsFixes #511