perf(ci): drop dead uvicorn start from perf job#917
Merged
Conversation
Since #915 the perf job gates only on test_frame_budget.py, which drives the CSIProcessor pipeline in-process and makes no HTTP calls. The "Start application" step (uvicorn + `sleep 10`) was therefore dead weight: it existed only for the now-excluded api_throughput/inference_speed tests, wasted ~10-15 s per main-push run, and dumped ~50 misleading "router requires hardware setup" ERROR lines into every CI log for a server no test touched. MOCK_POSE_DATA is server-only, unused here. Removed the step and the vestigial env. The gated test is unchanged and passes (verified locally, 3/3). Co-Authored-By: claude-flow <ruv@ruv.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After #915, the Performance Tests job gates only on
test_frame_budget.py, which drives theCSIProcessorpipeline in-process and makes no HTTP calls (grepconfirms noClientSession/localhost:8000/httpxin the gated test).That makes the "Start application" step (
uvicorn src.api.main:app … & sleep 10) pure dead weight:api_throughput/inference_speedmock tests;ERROR … router requires hardware setuplines into every CI log, for a server no test touches — making a green job look broken.Change
Remove the
Start applicationstep and the vestigialMOCK_POSE_DATAenv (server-only; unused byCSIProcessor/test_frame_budget.py).Install dependenciesis untouched (the test still needssrc.coredeps).Verification
test_frame_budget.pypasses 3/3 locally, independent of the server.ci.ymlre-validated as YAML.Docs/CI-only; no application code touched.
🤖 Generated with claude-flow