Conversation
fix lingering restructuring errors
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 68.23% 67.20% -1.04%
==========================================
Files 52 55 +3
Lines 1700 1857 +157
==========================================
+ Hits 1160 1248 +88
- Misses 540 609 +69
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| class HumanPhantomOutput: | ||
| """Create and handle a patient phantom data for output into a dict or JSON-string.""" | ||
|
|
||
| def __init__(self, phantom: Phantom): |
There was a problem hiding this comment.
missing docstring entries
| beam. | ||
| """ | ||
|
|
||
| def __init__(self, data_norm: pd.DataFrame): |
There was a problem hiding this comment.
missing docstring entries
| Table : Phantom | ||
| The treatment table as an instance of the Phantom class | ||
| Pad : Phantom | ||
| The treatment table pad as an instance of the Phantom class |
There was a problem hiding this comment.
same goes here, and so on...
Idea: lets skip this and then address language issues in a separate branch?
| patient : Phantom | ||
| An instance of the Phantom class that represents the patient | ||
| table : Phantom | ||
| An instance of the Phantom class that represents the treatment table |
There was a problem hiding this comment.
shouldnt it be "A phantom that represents the treatment table"?
It is clear from the "patient: Phantom" that the parameter table is of instance Phantom
There was a problem hiding this comment.
It can be considered clear that it is an instance of the phantom class from that but I believe it is more clear to read the text when we specify it this way. I think I would be more confused of reading the sentence when specifying the table as a phantom. But I'll leave i t up to you to decide :)
There was a problem hiding this comment.
this notebook output should be removed, right? It seems like the notebook output is online.
There was a problem hiding this comment.
I have removed it now
3 participants
No description provided.