Merged
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #47 +/- ##
==========================================
+ Coverage 65.57% 66.43% +0.85%
==========================================
Files 42 43 +1
Lines 1560 1585 +25
==========================================
+ Hits 1023 1053 +30
+ Misses 537 532 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BwKodex
reviewed
May 29, 2023
removed comments (use cases) for creating hvl data
pascal casing -> snake casing
fixed FutureWarning message when fetching k_med
fixed FutureWarning when fetching hvl
added inherent filtration to settings
added constant for inherent filtration
renaming of files/variables to snake_case
improved naming of table files
added missing docstring entry for inherent filtration
rename hvl table
improved hvl fetching
name change in example rdsr file
name change again
added limits of inherent filtration to docstring
unit and integration test for new hvl fetching
new hvl data
scripts for generating hvl data
updated name in test rdsr file
removed plot script
name change
fixed typo in filename
BwKodex
approved these changes
Jun 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PySkinDose crashed with Azurion RDSR since Azurion can below 50 kV (out of range in HVL table)
This fixes this issue.