chore: align plugin scripts with backstage-cli conventions#12
Merged
Conversation
Place the Documentation tab in Backstage's "documentation" entity content group so it appears in the correct tab section on entity pages. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Switch lint from tsc --noEmit to backstage-cli package lint (ESLint) - Add start and test scripts to both plugins - Add publishConfig dist entries for correct npm publishing - Add .eslintrc.js configs using backstage-cli eslint-factory - Add jest as devDependency (required by ESLint jest plugin) - Extract install and typecheck as separate Makefile targets - Reorder make all: typecheck → lint → format → build (fail fast) - Update CLAUDE.md to reflect new commands Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add format:check script to both plugins (prettier --check) - Update CI to use workspace format:check instead of raw prettier glob - Reorder CI steps: typecheck → lint → format → build (fail fast) - Add format:check target to Makefile Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tsc --noEmittobackstage-cli package lint(ESLint with Backstage's role-aware config)start,test,format:checkpublishConfigdist entries soprepack/postpackwork correctly for npm publishing.eslintrc.jsconfigs using@backstage/cli/config/eslint-factoryinstallandtypecheckas independent targets, addformat:checkTest plan
make typecheckpassesmake lintpasses (ESLint)make format:checkpassesmake buildpasses🤖 Generated with Claude Code