fix(rw-backend): use @backstage/errors for structured error handling#13
Merged
Conversation
Replace manual res.status().json() error responses with InputError and NotFoundError from @backstage/errors. Add 9 unit tests covering all router endpoints (health, config, navigation, pages) including error cases. Add test step to Makefile and CI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
yumike
force-pushed
the
fix/use-backstage-errors
branch
from
3e7e8ce to
305859b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
res.status().json()error responses withInputErrorandNotFoundErrorfrom@backstage/errors, letting Backstage's error middleware handle status codes consistently/health,/config,/navigation,/pages) including error cases (path traversal, not found, render failure)Test plan
🤖 Generated with Claude Code