add support for OpenBSD

[qbit]

This PR lets OpenRW build on OpenBSD! Game starts and is playable!

[JayFoxRox]

We depend on iconv on all platforms but will get rid of it soon (so this hack is fine).

[JayFoxRox]

This might be an absolutely stupid question, but we support FreeBSD already, wouldn't compiling for that also work for OpenBSD? (e.g. can't we just call it RW_BSD?)

---

//Edit (because the old comment was outdated, just a heads up):
"We depend on iconv on all platforms but will get rid of it soon (so this hack is fine)."

[mulander]

@JayFoxRox FreeBSD and OpenBSD are different kernels, user lands and available third party Libraries. While they do share some common ancestry code they are different systems with different feature sets. It might compile now but could soon become problematic with one OS lacking features of the other or implementing them in a vastly different way.

[krytarowski]

After merging it I will push NetBSD support.

[JayFoxRox]

PC did not explode, also did not forcefully download OpenBSD and shoved it on my harddrive.
Still works on Arch Linux.

Code review process was very hard and long but also passed:

LGTM

PS: I want at least one more LGTM from an OpenBSD user on this, possibly also MacOS or even Windows, I've already mentioned that on IRC.

//Edit: All 3 next "LGTM" were with the same version as the new one, only the commit name has changed between this and mulander's "LGTM"

[krytarowski]

OK from NetBSD user :)

[christoph-heiss]

+1 for macOS.

[mulander]

Waiting for GTA 3 game data to download before doing a test run on OpenBSD -current amd64

[mulander]

Tested on OpenBSD/amd64 -current

The game builds without issues and can be played. LGTM from an OpenBSD user :)

$ ./rwgame/rwgame
I [Game] Game directory: /home/mulander/Games/GTA3/
I [Game] Build: a8db29cd
Max UBO Size: 65536
UBO Alignment: 16
Max batch size: 512
I [Renderer] OpenGL Renderer Version: 3.3 (Core Profile) Mesa 11.2.2 (GLSL 3.30) Vendor: Intel Open Source Technology Center
I [Data] Loaded 42 zones from /home/mulander/Games/GTA3/data/gta3.zon
I [Game] Started
Error opening sound file "/home/mulander/Games/GTA3//audio/City.wav": System error : No such file or directory.
I [World] Loaded cutscene: BET
I [World] Loaded cutscene: JB
I [World] Creating Vehicle ID 116 (POLICAR)
I [World] Creating Vehicle ID 117 (ENFORCR)
I [World] Creating Vehicle ID 130 (RUMPO)
I [World] Creating Vehicle ID 96 (PATRIOT)
I [World] Creating Vehicle ID 110 (TAXI)
I [World] Creating Vehicle ID 105 (CHEETAH)
I [World] Creating Vehicle ID 92 (STINGER)
I [World] Creating Vehicle ID 105 (CHEETAH)
I [World] Creating Vehicle ID 92 (STINGER)
I [World] Creating Vehicle ID 111 (KURUMA)
I [World] Creating Vehicle ID 110 (TAXI)
I [World] Creating Vehicle ID 111 (KURUMA)
I [World] Creating Vehicle ID 110 (TAXI)
I [World] Creating Vehicle ID 111 (KURUMA)
I [World] Creating Vehicle ID 111 (KURUMA)
I [World] Creating Vehicle ID 111 (KURUMA)
I [World] Creating Vehicle ID 93 (LINERUN)
I [World] Creating Vehicle ID 108 (MOONBM)
I [World] Creating Vehicle ID 116 (POLICAR)
I [World] Creating Vehicle ID 116 (POLICAR)
I [World] Creating Vehicle ID 91 (IDAHO)
I [World] Creating Vehicle ID 130 (RUMPO)
I [World] Creating Vehicle ID 91 (IDAHO)
I [World] Creating Vehicle ID 109 (ESPERAN)
I [Game] Beginning cleanup
I [Game] Stopping work queue
I [Game] Cleaning up scripts
I [Game] Cleaning up renderer
I [Game] Cleaning up world
I [Game] Cleaning up state
I [Game] Cleaning up window
I [Game] Cleaning up work queue
I [Game] Done cleaning up

[danhedron]

+1 from me.

[brightersun99]

glad to see this never got anywhere