Skip to content

Streaming audio files#706

Merged
12 commits merged intomasterfrom
unknown repository
May 23, 2019
Merged

Streaming audio files#706
12 commits merged intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Apr 12, 2019

To think about:

  • smarter use of mutexes
  • testing with thread sanitizer
  • OpenAL issue:
OpenAL error at ../rwengine/src/audio/SoundBufferStreamed.cpp:22: Invalid value!
OpenAL error at ../rwengine/src/audio/SoundBufferStreamed.cpp:23: Invalid operation!

@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #706 into master will increase coverage by 0.02%.
The diff coverage is 20.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #706      +/-   ##
==========================================
+ Coverage   18.05%   18.08%   +0.02%     
==========================================
  Files         248      249       +1     
  Lines       22746    22861     +115     
  Branches     5752     5810      +58     
==========================================
+ Hits         4107     4134      +27     
- Misses      17540    17607      +67     
- Partials     1099     1120      +21
Impacted Files Coverage Δ
rwengine/src/audio/Sound.hpp 0% <ø> (-25%) ⬇️
rwengine/src/audio/SoundSource.hpp 0% <ø> (ø) ⬆️
rwengine/src/audio/SoundBuffer.cpp 48.38% <0%> (-0.77%) ⬇️
rwengine/src/audio/SoundSource.cpp 5.74% <0%> (+0.34%) ⬆️
rwengine/src/audio/Sound.cpp 48.64% <60%> (+1.77%) ⬆️
rwengine/src/audio/SoundManager.cpp 26.8% <64.7%> (+0.11%) ⬆️
tests/test_AudioLoading.cpp 59.37% <66.66%> (+1.31%) ⬆️
rwengine/src/audio/SoundBufferStreamed.cpp 9.57% <9.57%> (ø)
rwengine/src/objects/InstanceObject.cpp 7.73% <0%> (-0.12%) ⬇️
rwengine/src/objects/VehicleObject.cpp 11.47% <0%> (-0.12%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09d4662...94276d0. Read the comment docs.

@ghost ghost merged commit 685b78a into rwengine:master May 23, 2019
@ghost ghost deleted the feat/streaming branch May 23, 2019 13:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant