Add Gamma parameter to meta_analysis for sensitivity analysis#29
Merged
Conversation
- Add `gamma: float = 1.0` parameter to `meta_analysis` in `visualizations.py`. When gamma > 1, uses `adjusted_pvalue` with `bootstrap=False` instead of `pvalue`. - Add `bootstrap: bool = True` parameter to `adjusted_pvalue` in `base_classes.py`. When `bootstrap=False`, uses the normal approximation (sensitivity bounds ± z * se) instead of the percentile bootstrap, mirroring `expanded_confidence_interval`. https://claude.ai/code/session_01QCMYnc3sscL7n2VbZGA9Tv
Fix mypy override incompatibility: LinearCombinationEstimator and TreatmentEffectEstimator now include bootstrap: bool = True in their adjusted_pvalue signatures to match the base class. https://claude.ai/code/session_01QCMYnc3sscL7n2VbZGA9Tv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gamma: float = 1.0parameter tometa_analysisinvisualizations.py. When gamma > 1, usesadjusted_pvaluewithbootstrap=Falseinstead ofpvalue.bootstrap: bool = Trueparameter toadjusted_pvalueinbase_classes.py. Whenbootstrap=False, uses the normalapproximation (sensitivity bounds ± z * se) instead of the
percentile bootstrap, mirroring
expanded_confidence_interval.https://claude.ai/code/session_01QCMYnc3sscL7n2VbZGA9Tv