-
Notifications
You must be signed in to change notification settings - Fork 35
Start using release-plan for releases #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+787
−1,301
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,94 @@ | ||
name: Plan Release | ||
on: | ||
workflow_dispatch: | ||
push: | ||
branches: | ||
- main | ||
- master | ||
pull_request_target: # This workflow has permissions on the repo, do NOT run code from PRs in this workflow. See https://securitylab.github.com/research/github-actions-preventing-pwn-requests/ | ||
types: | ||
- labeled | ||
- unlabeled | ||
|
||
concurrency: | ||
group: plan-release # only the latest one of these should ever be running | ||
cancel-in-progress: true | ||
|
||
jobs: | ||
is-this-a-release: | ||
name: "Is this a release?" | ||
runs-on: ubuntu-latest | ||
outputs: | ||
command: ${{ steps.check-release.outputs.command }} | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 2 | ||
ref: 'master' | ||
# This will only cause the `is-this-a-release` job to have a "command" of `release` | ||
# when the .release-plan.json file was changed on the last commit. | ||
- id: check-release | ||
run: if git diff --name-only HEAD HEAD~1 | grep -w -q ".release-plan.json"; then echo "command=release"; fi >> $GITHUB_OUTPUT | ||
|
||
create-prepare-release-pr: | ||
name: Create Prepare Release PR | ||
runs-on: ubuntu-latest | ||
timeout-minutes: 5 | ||
needs: is-this-a-release | ||
permissions: | ||
contents: write | ||
issues: read | ||
pull-requests: write | ||
# only run on push event or workflow dispatch if plan wasn't updated (don't create a release plan when we're releasing) | ||
# only run on labeled event if the PR has already been merged | ||
if: ((github.event_name == 'push' || github.event_name == 'workflow_dispatch') && needs.is-this-a-release.outputs.command != 'release') || (github.event_name == 'pull_request_target' && github.event.pull_request.merged == true) | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
# We need to download lots of history so that | ||
# github-changelog can discover what's changed since the last release | ||
with: | ||
fetch-depth: 0 | ||
ref: 'master' | ||
- uses: pnpm/action-setup@v4 | ||
- uses: actions/setup-node@v4 | ||
with: | ||
node-version: 18 | ||
cache: pnpm | ||
- run: pnpm install --frozen-lockfile | ||
- name: "Generate Explanation and Prep Changelogs" | ||
id: explanation | ||
run: | | ||
set +e | ||
pnpm release-plan prepare 2> >(tee -a release-plan-stderr.txt >&2) | ||
|
||
if [ $? -ne 0 ]; then | ||
release_plan_output=$(cat release-plan-stderr.txt) | ||
else | ||
release_plan_output=$(jq .description .release-plan.json -r) | ||
rm release-plan-stderr.txt | ||
|
||
if [ $(jq '.solution | length' .release-plan.json) -eq 1 ]; then | ||
new_version=$(jq -r '.solution[].newVersion' .release-plan.json) | ||
echo "new_version=v$new_version" >> $GITHUB_OUTPUT | ||
fi | ||
fi | ||
echo 'text<<EOF' >> $GITHUB_OUTPUT | ||
echo "$release_plan_output" >> $GITHUB_OUTPUT | ||
echo 'EOF' >> $GITHUB_OUTPUT | ||
env: | ||
GITHUB_AUTH: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
- uses: peter-evans/create-pull-request@v7 | ||
with: | ||
commit-message: "Prepare Release ${{ steps.explanation.outputs.new_version}} using 'release-plan'" | ||
labels: "internal" | ||
branch: release-preview | ||
title: Prepare Release ${{ steps.explanation.outputs.new_version }} | ||
body: | | ||
This PR is a preview of the release that [release-plan](https://github.com/embroider-build/release-plan) has prepared. To release you should just merge this PR 👍 | ||
|
||
----------------------------------------- | ||
|
||
${{ steps.explanation.outputs.text }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
# For every push to the primary branch with .release-plan.json modified, | ||
# runs release-plan. | ||
|
||
name: Publish Stable | ||
|
||
on: | ||
workflow_dispatch: | ||
push: | ||
branches: | ||
- main | ||
- master | ||
paths: | ||
- '.release-plan.json' | ||
|
||
concurrency: | ||
group: publish-${{ github.head_ref || github.ref }} | ||
cancel-in-progress: true | ||
|
||
jobs: | ||
publish: | ||
name: "NPM Publish" | ||
runs-on: ubuntu-latest | ||
permissions: | ||
contents: write | ||
pull-requests: write | ||
id-token: write | ||
attestations: write | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: pnpm/action-setup@v4 | ||
- uses: actions/setup-node@v4 | ||
with: | ||
node-version: 18 | ||
# This creates an .npmrc that reads the NODE_AUTH_TOKEN environment variable | ||
registry-url: 'https://registry.npmjs.org' | ||
cache: pnpm | ||
- run: pnpm install --frozen-lockfile | ||
- run: npm install -g npm@latest # we are doing this to make sure theat the gloabally installed npm is new enough to support OIDC | ||
- name: Publish to NPM | ||
run: NPM_CONFIG_PROVENANCE=true pnpm release-plan publish | ||
env: | ||
GITHUB_AUTH: ${{ secrets.GITHUB_TOKEN }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,60 +1,27 @@ | ||
# Release Process | ||
|
||
Releases are mostly automated using | ||
[release-it](https://github.com/release-it/release-it/) and | ||
[lerna-changelog](https://github.com/lerna/lerna-changelog/). | ||
Releases in this repo are mostly automated using [release-plan](https://github.com/embroider-build/release-plan/). Once you label all your PRs correctly (see below) you will have an automatically generated PR that updates your CHANGELOG.md file and a `.release-plan.json` that is used to prepare the release once the PR is merged. | ||
|
||
## Preparation | ||
|
||
Since the majority of the actual release process is automated, the primary | ||
remaining task prior to releasing is confirming that all pull requests that | ||
have been merged since the last release have been labeled with the appropriate | ||
`lerna-changelog` labels and the titles have been updated to ensure they | ||
represent something that would make sense to our users. Some great information | ||
on why this is important can be found at | ||
[keepachangelog.com](https://keepachangelog.com/en/1.0.0/), but the overall | ||
guiding principle here is that changelogs are for humans, not machines. | ||
|
||
When reviewing merged PR's the labels to be used are: | ||
|
||
* breaking - Used when the PR is considered a breaking change. | ||
* enhancement - Used when the PR adds a new feature or enhancement. | ||
* bug - Used when the PR fixes a bug included in a previous release. | ||
* documentation - Used when the PR adds or updates documentation. | ||
* internal - Used for internal changes that still require a mention in the | ||
changelog/release notes. | ||
|
||
## Release | ||
Since the majority of the actual release process is automated, the remaining tasks before releasing are: | ||
|
||
Once the prep work is completed, the actual release is straight forward: | ||
- correctly labeling **all** pull requests that have been merged since the last release | ||
- updating pull request titles so they make sense to our users | ||
|
||
* First, ensure that you have installed your projects dependencies: | ||
|
||
```sh | ||
npm ci | ||
``` | ||
|
||
* Second, ensure that you have obtained a | ||
[GitHub personal access token][generate-token] with the `repo` scope (no | ||
other permissions are needed). Make sure the token is available as the | ||
`GITHUB_AUTH` environment variable. | ||
|
||
For instance: | ||
Some great information on why this is important can be found at [keepachangelog.com](https://keepachangelog.com/en/1.1.0/), but the overall | ||
guiding principle here is that changelogs are for humans, not machines. | ||
|
||
```bash | ||
export GITHUB_AUTH=abc123def456 | ||
``` | ||
When reviewing merged PR's the labels to be used are: | ||
|
||
[generate-token]: https://github.com/settings/tokens/new?scopes=repo&description=GITHUB_AUTH+env+variable | ||
- breaking - Used when the PR is considered a breaking change. | ||
- enhancement - Used when the PR adds a new feature or enhancement. | ||
- bug - Used when the PR fixes a bug included in a previous release. | ||
- documentation - Used when the PR adds or updates documentation. | ||
- internal - Internal changes or things that don't fit in any other category. | ||
|
||
* And last (but not least 😁) do your release. | ||
**Note:** `release-plan` requires that **all** PRs are labeled. If a PR doesn't fit in a category it's fine to label it as `internal` | ||
|
||
```sh | ||
npx release-it | ||
``` | ||
## Release | ||
|
||
[release-it](https://github.com/release-it/release-it/) manages the actual | ||
release process. It will prompt you to to choose the version number after which | ||
you will have the chance to hand tweak the changelog to be used (for the | ||
`CHANGELOG.md` and GitHub release), then `release-it` continues on to tagging, | ||
pushing the tag and commits, etc. | ||
Once the prep work is completed, the actual release is straight forward: you just need to merge the open [Plan Release](https://github.com/rwjblue/codemod-cli/pulls?q=is%3Apr+is%3Aopen+%22Prepare+Release%22+in%3Atitle) PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.