Conversation
Member
|
Looks good, I corrected a minor formatting issue. Let's see how it plays. |
Member
|
By the way, PR your language changes to https://github.com/rwmt/Multiplayer-Locale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Faction Sidebar Changes
Layouter.cs.Select Random Sitebutton added.World Factionsbutton added.Locate on mapbutton added for Join Faction list.factionsidebar.mp4
Spectator Changes
Colonist Barremoved.World Route Plannerremoved.Send Caravanremoved.Questsremoved.MainButtonDefexcept for theMenuandWorldones removed.Quests Tab Changes
questtab.mp4
Colonist Bar Changes
hide.mp4
Other
hideOtherPlayersInColonistBar,hideOtherPlayersQuestsadded toMpSettings(default:false)Faction Sidebar,Quest Tab, andSettingsadded to theMultiplayer.xml.I tested it in both vanilla and Multiplayer (without multifaction), and everything seemed to work fine.
This is my first time working on a RimWorld mod, creating a pull request, and using Harmony. Feel free to question or suggest changes.