Performance recorder - Circular buffer, general improvements#582
Merged
Performance recorder - Circular buffer, general improvements#582
Conversation
Member
|
While this is a purely debuging tool that users won't see, the arbitrary limits seem strange. These constants could be available to change without recompile. |
Author
|
The idea was to limit it so that the recorder itself doesn't slowly cause performance to degrade. But you're right, I'll add them to debug options. |
Author
|
Added the options to the debug panel itself to prevent taking up space in the main mod options with settings most users will never use. Went with sliders to prevent capturing key input events while the game is running. |
notfood
approved these changes
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
PerformanceRecorderclass to replace lists with CircularBuffer for improved memory management and performance tracking, along with other misc improvements.PerformanceRecorderclass changes:CircularBufferfor performance metrics, allowing for a rolling window of data.MaxSampleCountandNonPerfMetricsFrameIntervalto limit buffer size and non-performance metric sample rate.