Fix scenario research lost on reconnect (#585)#588
Merged
Conversation
Fix for rwmt#585 . ScenPart_StartingResearch.PostGameStart was only executed on the local machine of the faction creator. As a result, the host/save did not reflect this change properly. I’ve opened an issue rwmt#587 to improve the overall handling of ScenParts. I believe there’s more to gain by reviewing the other available part scenParts. I’ve added this as a TODO for future work.
notfood
added
fix
notfood
pushed a commit
that referenced
this pull request
Jul 21, 2025
Fixes #585 . ScenPart_StartingResearch.PostGameStart was only executed on the local machine of the faction creator. As a result, the host/save did not reflect this change properly. I’ve opened an issue #587 to improve the overall handling of ScenParts. I believe there’s more to gain by reviewing the other available part scenParts. I’ve added this as a TODO for future work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Label: 1.5, 1.6, Bug, Multifaction
Fixes #585.
Tested on 1.6 (dev) and 1.5 (rw-1.5)
ScenPart_StartingResearch.PostGameStartwas only executed on the local machine of the faction creator.As a result, the host/save did not reflect this change properly.
I’ve opened an issue (#587) to improve the overall handling of ScenParts. I believe there’s more to gain by reviewing the other available scenParts and their methods. I’ve added this as a TODO for future work.