Skip to content

A few internal improvements#598

Merged
notfood merged 5 commits intorwmt:devfrom
mibac138:misc
Jul 23, 2025
Merged

A few internal improvements#598
notfood merged 5 commits intorwmt:devfrom
mibac138:misc

Conversation

@mibac138
Copy link
Copy Markdown
Member

Each commit is self-contained and small, so grouping them into a single PR seems reasonable.

@notfood notfood added enhancement New feature or request. 1.6 Fixes or bugs relating to 1.6 (Not Odyssey). labels Jul 22, 2025
@notfood notfood moved this to In review in 1.6 and Odyssey Jul 22, 2025
@notfood
Copy link
Copy Markdown
Member

notfood commented Jul 22, 2025

Isn't max packet size already handled by LiteNetLib? I remember seeing a similar error before.

@mibac138
Copy link
Copy Markdown
Member Author

LNL has both a limit for a single packet as well as for packets it internally fragments (here). However, when we fragment the packet ourselves, LNL doesn't know about the whole packet's size and thus it cannot make sure the packet has a reasonable size.
Also, we verify the packet's size when receiving a fragmented packet (here) so I think it makes sense to also verify it ourselves when sending a packet and possibly catching an issue earlier.

@notfood notfood merged commit ab1a9d5 into rwmt:dev Jul 23, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from In review to Done in 1.6 and Odyssey Jul 23, 2025
@mibac138 mibac138 deleted the misc branch July 23, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.6 Fixes or bugs relating to 1.6 (Not Odyssey). enhancement New feature or request.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants