Skip to content

Fix camp is not abandoned correctly when reforming the caravan and relating problems#603

Merged
notfood merged 5 commits intorwmt:devfrom
Tick-git:Fix-Camp-not-removed-on-caravan-reform
Jul 28, 2025
Merged

Fix camp is not abandoned correctly when reforming the caravan and relating problems#603
notfood merged 5 commits intorwmt:devfrom
Tick-git:Fix-Camp-not-removed-on-caravan-reform

Conversation

@Tick-git
Copy link
Copy Markdown
Contributor

@Tick-git Tick-git commented Jul 28, 2025

Label: 1.6, Fix

  • Refactor camp creation
    • Fix warning after refactor
  • Fix camp is not abandoned correctly on reforming the caravan
  • Fix vtr patch out of bounce error on removing camps/settlements

Tick-git added 5 commits July 27, 2025 20:42
Fixing camp not abandoning on caravan reform in multiplayer and disabled this patch in singleplayer, because it happend there as well.
In map deinitialize and removal process it gets removed from game.maps.
If it is the last map added then this patch throws a out of bounce exception in the removal process due to calling Find.CurrentMap while currentMapIndex points to an invalid index.
The patch could not find a faction for the current tile and threw a warning. This commit includes caravans into the search for a faction at the tile
@notfood notfood added fix Fixes for a bug or desync. 1.6 Fixes or bugs relating to 1.6 (Not Odyssey). labels Jul 28, 2025
@notfood notfood merged commit bb5e068 into rwmt:dev Jul 28, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from In review to Done in 1.6 and Odyssey Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.6 Fixes or bugs relating to 1.6 (Not Odyssey). fix Fixes for a bug or desync.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants