Merged
Conversation
This fix normalizes method names by cutting this part: at Verse.Rand.RangeInclusive (int,int) >>>>>>>>>>>>>>>>>>>>>>>>>>>>> [0x00010] in <5ad0188af7874f079052550c95a7a031>:0 <<<<<<<<<<<<<<<<<<<<<<<<<<<<
notfood
added
fix
Tick-git
added a commit
to Tick-git/Multiplayer
that referenced
this pull request
Aug 31, 2025
RBD probing was originally to address 1.6 issues with crossplay between Windows and Linux, as well as when players were not using the same build of the mod. This issue has now been resolved by rwmt#623. The probing caused errors when a constructor was invoked via reflection. I don’t have an explanation for why this is happening, but it’s not worth investigating at the moment, as we are reverting the code to the state that Zetrith implemented, along with the rwmt#623 fix.
notfood
pushed a commit
that referenced
this pull request
Sep 1, 2025
RBD probing was originally to address 1.6 issues with crossplay between Windows and Linux, as well as when players were not using the same build of the mod. This issue has now been resolved by #623. The probing caused errors when a constructor was invoked via reflection. I don’t have an explanation for why this is happening, but it’s not worth investigating at the moment, as we are reverting the code to the state that Zetrith implemented, along with the #623 fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Label: 1.6, Fix
With the Mono update in 1.6, method names now include additional build- and platform-specific details, which breaks cross-platform consistency.
This PR removes the new Mono 1.6 extra data to restore consistent cross-platform stack trace hashing.
I believe this should fix all cross-OS play. It has been tested on Linux/Windows.
Desync file example below for #621 in 1.5 and 1.6
Behavior in 1.5
In Mono 1.5, stack traces included a postfix like
<0xffffffff>.Behavior in 1.6
In Mono 1.6, the format changed to
[0x00025] in <b994eb69d2df47fdb01add71b9ac29d2>:0.This extra data maps the method to a specific assembly and changes with each build.
Because RimWorld assemblies differ between Linux and Windows, these values also differ between platforms, causing desync issues.