Conversation
- Synced up some of the basic for traveliing, works with no desync if temp terrain and vtr are off. - Fixed some issues with map swapping.
- Reenabled vtr - Synced dev tools for Pilot Console and Breakdownable.
… specs. Syncing landing outcome defs Cleaned up some things, remove unnecessary sync methods.
- Added serialization for Designator_MoveGravship - Added some scribe data to GravshipTravelSession - still needs work - Moved Cancelling while in world map so that it is only checked and called when cancelled, not selected.
A recent commit introduced a change that causes session cancellation to result in a desync and leaving the session open.
This commit fixes an incorrect call to TilePicker.StopTargeting on non-Issuers when the gravship has a valid destination tile selected and is about to start. Issuers clean up the TargetPicker after selecting a valid tile and preparing to launch the gravship. This commit introduces the same behavior for non-Issuers.
Refactor to use the original method for StopTargeting. I spent quite a while trying to find what in the source code causes the map to not close for the non-issuer. I found that, for the issuer, the wantedMode is set to None and for the issuer to planet, but I couldn’t find where this happens in the source code. So I just set it manually.
The gravship travel session was not closed correctly, so it was saved and caused errors on the next load.
This commit fixes loading session errors, and joining a client during takeoff, landing, or an active session is now possible. When a user joins, the current session is canceled. This works well for the takeoff session. In the landing session, however, when the landing position is selected, the session is not recreated. As a result, the time can still be controlled. I think this is fine for now, but I’ll note it down for future change. We now use separate takeoff and landing sessions. The world session has been removed. Exposable sessions have also been removed.
The take-off session wasn’t opened due to a different code path, so our prefix for opening the session was never executed. In other words, the map destruction confirmation window isn’t displayed because the map itself isn’t being destroyed with a anchor.
Flying back to an anchored map is handled differently. Fixes: Map could not be found when opening a session due to the marker being initialized differently. Marker could not be synced correctly because it was not spawned or did not have a parent map. Deselects the gravship designator if another client selects a landing position.
Removes half copied WorldComponentOnGUI and syncs the confirmation button in another way.
This commit implements the abort button which redirects you to a random map nearby. I did experience really rare Rand problems, where a other abort map was picked between clients.
notfood
added
fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Label: 1.6 Odyssey
This is a polished version of @Reznal’s SPACESHIP branch.
This PR introduces the following gravship behaviors:
Known issues:
There are still some parts to refactor. This should be seen as a first iteration, intended to make collaboration easier.