Conversation
…n circumstances `TickManagerPausedPatch` was not running in MP if `WorldRendererUtility.WorldRendered`. However, we wanted to use `WorldRendererUtility.WorldSelected`, as the former checks if the world is rendered at all, while the latter checks if the world is rendered due to the player opening the world map. There's several bugs that could happen due to this: - Camera shaker running while paused - Normally `CameraShaker:ShakeOffset` returns `Vector3.zero` while paused - Audio samples being paused while the game is running, not pausing while the game is paused, or having incorrect pitch/volume - `FleckMaker:ThrowMetaPuffs` creating flecks while paused - This method normally only does it while unpaused - Possibly more in vanilla, and likely a lot more with mods As for reproduction steps of the bug: - Start async time MP game with 2 maps, one of which is in space - Pause both maps - Switch to the planet map, unpause - Switch to space map, use dev mode to create explosions - Notice that the explosions make the camera shake immediately - If you compare to the planet maps, the shaking never happens while paused
SokyranTheDragon
added
fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TickManagerPausedPatchwas not running in MP ifWorldRendererUtility.WorldRenderedis true. However, we wanted to useWorldRendererUtility.WorldSelected, as the former checks if the world is rendered at all (including as a background for space maps), while the latter checks if the world is rendered due to the player opening the world map.There's several bugs that could happen due to this:
CameraShaker:ShakeOffsetreturnsVector3.zerowhile pausedFleckMaker:ThrowMetaPuffscreating flecks while pausedAs for reproduction steps of the bug: