Conversation
`PreceptComp_UnwillingToDo_Chance:MemberWillingToDo` uses RNG, which may be called in interface or other places that cause issues. In vanilla, this only affects "marriage name" issue, specifically when set to "usually man's" or "usually woman's" (when playing without Ideology, it uses the former). I've seeded the method using the pawn's ID (if present, using `Find.World.ConstantRandSeed` as fallback) combined with the current tick to ensure results are unique for each pawn, but will always be the same on a given tick. The fallback is mostly a precaution, as this precept comp is expecting a pawn. This should fix desyncs that are sometimes caused due this precept comp. This could probably be handled in a smarter way, so if anyone has an idea on how and is willing to do it - go ahead make it better.
SokyranTheDragon
added
fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PreceptComp_UnwillingToDo_Chance:MemberWillingToDouses RNG, which may be called in interface or other places that cause issues.In vanilla, this only affects "marriage name" issue, specifically when set to "usually man's" or "usually woman's" (when playing without Ideology, it uses the former).
I've seeded the method using the pawn's ID (if present, using
Find.World.ConstantRandSeedas fallback) combined with the current tick to ensure results are unique for each pawn, but will always be the same on a given tick. The fallback is mostly a precaution, as this precept comp is expecting a pawn.This should fix desyncs that are sometimes caused due this precept comp.
This could probably be handled in a smarter way, so if anyone has an idea on how and is willing to do it - go ahead make it better.