Conversation
Launching a gravship from an anchored map failed to create the session correctly when the world tile picker is selected. This bug was introduced by my recent refactor of GravshipTravelSessionPatches.cs. The fix updates how preconfirm dialog options are synced, removing the need to sync `StartChoosingDestination_NewTemp`, where the postfix and `!Multiplayer.ExecutingCmds` check caused the issue. Additionally, removed some code that was needed because the method was synced.
notfood
added
fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Label: 1.6, Fix, Odyssey
Launching a gravship from an anchored map failed to create the session correctly when the world tile picker is selected.
This bug was introduced by my recent refactor of GravshipTravelSessionPatches.cs.
The fix updates how preconfirm dialog options are synced, removing the need to sync
StartChoosingDestination_NewTemp, where the postfix and!Multiplayer.ExecutingCmdscheck caused the issue.Additionally, removed some code that was needed because the method was synced.