Conversation
It can easily generate over 150kB of data. Moving it out to a separate file makes sense content-wise and makes it easier to browse the log file
Internally Harmony.VersionInfo iterates over all patched methods and gets generates PatchInfo for each of them. This is something we already do ourselves for describing the patched methods list. This probably woudn't be much of a issue, however PatchInfos are stored at rest only as a serialiazed binary blob, which means they all are deserialized when generating the report. The base game with this mod has over 1000 patches which causes the whole process to be time consuming.
notfood
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a debug action to trigger a desync, improves desync generation by: making it faster, on my system it takes ~0.9s, where as before it took ~1.8s; the game no longer freezes when saving the desync report (saving now takes ~50ms, because the slowest code is run in the background - metadata generation); added a new file to the desync report with just the metadata (mods, patches, harmony versions).