Improve handling of packets when loading#668
Merged
Conversation
As long as a player isn't fully loaded it doesn't make sense to send those packets.
The server sends them regardless if the client is already playing or just loading. While the server could be made to only send those packets after the client has finished loading, the packets are generally simple enough to be easily handled during loading too.
It doesn't make sense to send cursor position to server when the client might not even see the map yet
notfood
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a client is joining a server, the server sends a lot of packets during client loading that aren't properly handled (or shouldn't actually be sent). Now, the Server_Cursor packet is only sent to players that are already loaded (as it doesn't make sense to send it to players that are loading), and Server_KeepAlive and Server_TimeControl are now handled by the client during loading time too.