Merged
Conversation
SokyranTheDragon
added
enhancement
Member
Author
|
So to sum this up, if you make a plan then only your faction will be able to see it and no other faction. So it'll work the same as zones, designators, areas, etc. |
SokyranTheDragon
added a commit
to SokyranTheDragon/Multiplayer
that referenced
this pull request
Sep 8, 2025
rwmt#670 was causing errors due to the `planManager` field being null when exposing data, so to fix it I've made sure it's created if null. However, I've decided to initialize all relevant map/world faction fields if null for all factions in case of any weird errors or issues.
notfood
pushed a commit
that referenced
this pull request
Sep 8, 2025
#670 was causing errors due to the `planManager` field being null when exposing data, so to fix it I've made sure it's created if null. However, I've decided to initialize all relevant map/world faction fields if null for all factions in case of any weird errors or issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
PlanManagertoFactionMapData, initialized it, and exposed. It'll also be applied fromSetFactioncall.I'll be honest, I expected this to need much more work than it actually was? Everything seems to be handled due to the faction being set properly where it needs to be set. Everything seems to work fine on my end.
Unrelated to this PR, but we may need to double-check the plan renaming feature since it seems to cause a double write/read.