Introduce a window based notification when a player requests to join#686
Merged
Introduce a window based notification when a player requests to join#686
Conversation
|
I think it would look nicer if it slid out as well as sliding in. But RimWorld doesn't really do animated windows so it would fit the style if it did just hide. |
Member
Author
|
I consider sliding out to be a possible future improvement. When first implementing this, I wanted to implement sliding out too, even if to just see how it looks like, but it's more complicated and has some additional edge-cases to consider, so I just left it at sliding in only for now. |
notfood
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old way of accepting through the chat window is not removed. The new window uses vanilla Rimworld's translation keys:
AcceptandRejectLetter. While the former I think is fine, the second might be better to have our translation for? Not sure about that. I did not test this using Steam, only with LAN connections (with some crutches I made local connections to require acceptance). Some of the new methods in RectExtensions are currently unused, but I felt they might be useful in the future.2025-09-16.01-24-27-1.mp4