Conversation
notfood
added
fix
Contributor
Author
|
This auto merge sucks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #848
this allows you send transporters with pawns from your friend's faction-base to world-map tile form caravan instead of missing.
this is not fully fixing transporter's logic because I'm detecting inside pawn's faction and assigin it to the transporter flying on the sky, means if there's no pawn inside this will fall back to faction.OfPlayer, so you can't send gift to other factions or it'll calculated as the faction-base-owner's gift.
Use the building with complaunchable's faction should works better than this PR, but that changes a lot, I tried to pass faction info like compTansporter.faction->flyShipLeaving.faction->travellingTransporters.faction , but flyShipLeaving.def.CanHaveFaction is False.