Skip to content

Skip VTR map updates during joinpoint reload#865

Merged
notfood merged 1 commit intorwmt:devfrom
MhaWay:joinpoint-vtr-map-state
Apr 7, 2026
Merged

Skip VTR map updates during joinpoint reload#865
notfood merged 1 commit intorwmt:devfrom
MhaWay:joinpoint-vtr-map-state

Conversation

@MhaWay
Copy link
Copy Markdown

@MhaWay MhaWay commented Apr 7, 2026

Fixes #862

Summary

  • suppress viewed map updates while SaveAndReload is in progress
  • reuse the existing Multiplayer.reloading flag instead of adding new state
  • clear VTR resend bookkeeping on reset so the reloaded client starts from a clean sync state

Validation

  • dotnet build Source/Client/Multiplayer.csproj -c Release

Copilot AI review requested due to automatic review settings April 7, 2026 09:21
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses join point save/reload inconsistencies by preventing viewed-map tracking updates from being sent while SaveAndReload() is in progress, and by ensuring VTR map resend bookkeeping is fully reset when multiplayer stops.

Changes:

  • Skip sending viewed-map (PlayerCount) updates while Multiplayer.reloading is true.
  • Reset VTRSync.lastSentAtTick alongside lastMovedToMapId so a fresh session doesn’t inherit resend suppression state.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@notfood notfood added standalone server Fix or bugs relating to the standalone server. 1.6 Fixes or bugs relating to 1.6 (Not Odyssey). labels Apr 7, 2026
@notfood notfood merged commit e00581c into rwmt:dev Apr 7, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.6 Fixes or bugs relating to 1.6 (Not Odyssey). standalone server Fix or bugs relating to the standalone server.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants