Conversation
notfood
added
fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for https://discord.com/channels/524286515644203028/568070216626470922/1493717766006374552
played for 1 day and haven't met a desync during compats yet. the deep-copy seems not affecting performance very much, I didn't really noticed the tps drop so maybe need to use performance analyser to judge this.
I also have a version that logging whether the postion changed in tick or threads read it first. And I'd put my test results here too.
Host side:
Threads read first. for my save when I got manhunting incident with 100 wolfs can see the ticks run first for many of them.
Client side:
mostly threads read first, but still sometimes got ticks run first without a battle, I believe this is why sometimes we observe a wild animal trigger a desync randomly.
multithread issues got random chance happening due to player's computer set, so I can only say that it triggers a bit often on my enviroment.